fix(server): derive standalone SSE streamId per-session to prevent EventStore collisions#2109
Open
leehpham wants to merge 1 commit into
Open
Conversation
…entStore collisions.
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004.
WebStandardStreamableHTTPServerTransporthardcoded_standaloneSseStreamIdto the literal'_GET_stream', so when multiple transport instances shared anEventStore(e.g. Redis-backed for horizontal scaling), every session's GET-SSE notifications were stored under the samestreamId- breaking per-session replay isolation.This converts the field to a getter returning
`_GET_stream_${sessionId}`once a session is initialized, preserving the original'_GET_stream'literal in stateless mode for backward compatibility. The_streamMappingis per-instance so its keying is unaffected.Adds a regression test that runs two transports with distinct sessions against one shared
EventStoreand asserts the recordedstreamIds are distinct, plus a stateless-mode test pinning the literal fallback.