fix: validate wrapped Zod output schemas#2106
Open
pragnyanramtha wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: b0e8d74 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
structuredContentagainst the registered output schema directly instead of first normalizing it to a plain object schema@modelcontextprotocol/sdkFixes #1308.
Related prior work: this revives the behavior covered by closed, unmerged #1931, with the current fix scoped to preserving the registered schema wrapper and with Zod v3/v4 regression coverage.
Validation
npx vitest run test/server/mcp.test.ts -t "wrapped and union"npx vitest run test/server/mcp.test.tsnpm run typechecknpm run lintnpm run buildnpx prettier --check .changeset/validate-wrapped-output-schemas.mdgit diff --checkNote: I also started
npm test; it passed the changed server suite and several unrelated suites, then stopped producing output for more than 10 minutes in this environment, so I stopped that run and relied on the targeted/full server suite plus typecheck/lint/build.