fix: reject init header/body version mismatch#853
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #852
Motivation and Context
When a client sends an
initializerequest and theMCP-Protocol-VersionHTTP header doesn't match theparams.protocolVersionvalue in the JSON-RPC body, the Streamable HTTP server accepts the request without any notification. According to the MCP 2025-11-25 spec's Protocol Version Header section, an invalid or unsupportedMCP-Protocol-Versionshould return a400 Bad Request. A header that contradicts the body shows a clear inconsistency on the client side and should be rejected before the session is established.How Has This Been Tested?
Added intergration tests.
Breaking Changes
None
Types of changes
Checklist
Additional context
This change aligns with the fix in the TypeScript SDK modelcontextprotocol/typescript-sdk#2111 and the spec PR modelcontextprotocol/modelcontextprotocol#2721. When the header is missing, which is expected during the first initialize round-trip before any version has been negotiated, the request will still go through as usual.