SEP-837: application_type check in DCR registration#284
Open
localden wants to merge 1 commit into
Open
Conversation
SEP-837 requires MCP clients to specify an appropriate application_type during Dynamic Client Registration so OIDC authorization servers can apply the correct redirect-URI constraints. - Traceability yaml: 1 check (presence + valid value), 4 excluded (class-specific SHOULDs unobservable; UI/robustness) - Check added in the shared createAuthServer DCR handler so it fires in every auth scenario that performs DCR (no new scenario) - withOAuthRetry now sets application_type: native (passing example; the conformance example clients are CLI tools) - New auth-test-no-application-type negative client + vitest case
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283.
Adds
sep-837-application-type-presentper SEP-837: clients MUST specify an appropriateapplication_typeduring Dynamic Client Registration. The harness can't know the client's real class (native vs web) so the check asserts presence + that the value is one of the two OIDC-defined values.What changed
src/seps/sep-837.yaml: 1check:, 4excluded:(class-specific SHOULDs unobservable; UI/robustness)createAuthServer/registerhandler so it fires in every DCR-using auth scenario — no new scenario per the fewer-scenarios rulewithOAuthRetrynow setsapplication_type: 'native'(the conformance example clients are CLI tools)auth-test-no-application-type.ts(omits the field) + vitest caseOutput —
node dist/index.js client --scenario auth/metadata-defaulteverything-clientsep-837-application-type-presentSUCCESS ("native")auth-test-no-application-typesep-837-application-type-presentFAILUREnpm test: auth suite 28/28; lefthook pre-push 127/127.