-
Notifications
You must be signed in to change notification settings - Fork 4
Separate Azure Envs for Dev/Prod #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moconnell
wants to merge
2
commits into
develop
Choose a base branch
from
127-azure-environments-should-be-segregated
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| @description('Globally unique Key Vault name for this environment') | ||
| param keyVaultName string | ||
|
|
||
| @description('Environment name (dev or prod)') | ||
| @allowed([ | ||
| 'dev' | ||
| 'prod' | ||
| ]) | ||
| param environmentName string | ||
|
|
||
| @description('Location for the Key Vault') | ||
| param location string = resourceGroup().location | ||
|
|
||
| @description('Tags to apply to the Key Vault') | ||
| param tags object = {} | ||
|
|
||
| resource keyVault 'Microsoft.KeyVault/vaults@2023-07-01' = { | ||
| name: keyVaultName | ||
| location: location | ||
| tags: union(tags, { | ||
| Environment: environmentName | ||
| ManagedBy: 'GitHub' | ||
| }) | ||
| properties: { | ||
| tenantId: subscription().tenantId | ||
| enableRbacAuthorization: true | ||
| enableSoftDelete: true | ||
| softDeleteRetentionInDays: 90 | ||
| enablePurgeProtection: true | ||
| // GitHub-hosted runners and operator workstations do not have stable egress IPs. | ||
| // Keep the data-plane endpoint public; Entra authentication and vault-scoped RBAC | ||
| // remain mandatory for both deployments and manual secret maintenance. | ||
| publicNetworkAccess: 'Enabled' | ||
| networkAcls: { | ||
| bypass: 'None' | ||
| defaultAction: 'Allow' | ||
| ipRules: [] | ||
| virtualNetworkRules: [] | ||
| } | ||
| sku: { | ||
| family: 'A' | ||
| name: 'standard' | ||
| } | ||
| } | ||
| } | ||
|
|
||
| output keyVaultId string = keyVault.id | ||
| output keyVaultUri string = keyVault.properties.vaultUri | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.