fix: update geolocation fallback API and use static country code mapping#1104
Open
ucodia wants to merge 2 commits intomlco2:masterfrom
Open
fix: update geolocation fallback API and use static country code mapping#1104ucodia wants to merge 2 commits intomlco2:masterfrom
ucodia wants to merge 2 commits intomlco2:masterfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes geolocation fallback API call
Issue 1
The fallback API will always fail when using the HTTPS endpoint
Using the HTTP endpoint is not great because this could expose the application location to eavesdropper and be vulnerable to man-in-the-middle.
Issue 2
If the fallback API call fails, it reports on the wrong URL on the exception: https://github.com/ucodia/codecarbon/blob/ebc8d1a3f5dcae9013dcbe6883d05e711ad6ce28/codecarbon/external/geography.py#L136
Non-issue 1
The current fallback relies on another API to map the 2 letters country code to a 3 letters code. This is static data that almost never changes, by switching to a static mapping provider we can make the fallback more resilient.
Related Issue
Fixes #1101
Motivation and Context
Certain IP ranges are not covered by the primary API and therefore a fallback is necessary otherwise CodeCarbon client will estimate on the wrong energy mix.
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.