Add warning about stability to doc comment for internals module#648
Merged
max-sixty merged 1 commit intomitsuhiko:masterfrom Oct 7, 2024
Merged
Conversation
Collaborator
|
Thanks @lasernoises ! I tagged @mitsuhiko in case he has any views, will merge now and we can make changes later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #610 it probably makes sense to be explicit about the
internalsmodule not being guaranteed to be stable.I also noticed that
TextSnapshotKindgets exposed globally. This was added in #581 when it was still calledSnapshotKind. I wonder if this is necessary to expose toplevel.