feat(convert): support color-related optional arguments for commands#213
Merged
Conversation
- refactor: get-tex-color() - add `convert_command_color` for color command
OrangeX4
approved these changes
Apr 4, 2026
Member
|
Sorry, I haven't had time to deal with mitex-related PRs before, thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #212, #206. This PR refactors the parsing and code generation logic for color-related commands in
converter.rsand updates the corresponding definitions instandard.typ. It now provides full support for optional arguments such as[rgb],[RGB],[HTML],[cmyk], and[gray]color models for\color,\textcolor, and\colorbox.For #206
For #212
Features
For
\colorcommandFor
\textcolorcommandblue!50!green) are currently not supported. I plan to implement this in a future update.For
\colorboxcommand\colorboxcommand align with the latex default value, see: Colored-boxes.bodyis empty, which is consistent with the behavior of LaTeX.#mitex().Warning
To preserve some of Typst's aesthetic, I set
radius: 2pt, if this is deemed inconsistent with mitex's status as a LaTeX converter, please remove it.