straightline_cleanup: limit cbn [interp_binop] to goal only#531
Open
spitters wants to merge 1 commit into
Open
straightline_cleanup: limit cbn [interp_binop] to goal only#531spitters wants to merge 1 commit into
spitters wants to merge 1 commit into
Conversation
The straightline_cleanup tactic runs `cbn [Semantics.interp_binop] in *` on every iteration, which forces a full normalization pass over every hypothesis in scope. In bedrock2 WP proofs, hypotheses accumulate (sep clauses, locals, typing facts), and interp_binop never appears in hypotheses — it's introduced only by cmd unfolding in the goal. Restricting cbn to the goal removes a quadratic-in-hypothesis-count overhead on long straightline chains. Measured on AUCurves's BLS12_MSM.v (~600 LoC WP proof with ~50 accumulated hyps at peak): straightline cleanup overhead drops ~30% wall, no proof regressions in our downstream tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
straightline_cleanuptactic inbedrock2/src/bedrock2/ProgramLogic.vrunscbn [Semantics.interp_binop] in *on every iteration, which forces a full normalization pass over every hypothesis in scope. In bedrock2 WP proofs, hypotheses accumulate (sep clauses, locals, typing facts), andinterp_binopnever appears in hypotheses — it's introduced only bycmdunfolding in the goal.Restricting
cbnto the goal removes a quadratic-in-hypothesis-count overhead on long straightline chains.Diff
```diff
```
Test plan