Move adding spaces around punctuation to top - #204
Open
fahadh4ilyas wants to merge 3 commits into
Open
Conversation
If adding space around each punctuation put after `train_new_model`, the Tokenizer didn't count punctuation as a whole word and didn't separate the sentence `"this sentence?"` to `["this", "sentence", "?"]` but into `["this", "sentence?"]`.
Simplify train from text by only call `train_on_texts` so the punctuation problem applied to train from text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If adding space around each punctuation put after
train_new_model, the Tokenizer didn't count punctuation as a whole word and didn't separate the sentence"this sentence?"to["this", "sentence", "?"]but into["this", "sentence?"].