No crash on unknown socktype#24
Open
GameParrot wants to merge 2 commits intominecraft-linux:masterfrom
Open
Conversation
This was referenced May 27, 2023
|
Any update on this? |
|
How do you use this? |
|
You have to build the launcher from source using these new commits instead of the defaults in libc-shim when compiling from source. It's in one of the build steps. As of right now, as a Wayland/Hyprland user, I broke everything X11, so I can't help more at the moment. If you're wondering how I broke my X11 display, know I use Gentoo. Edit: I built my launcher from source and it worked perfectly fine; except for this error of course. |
|
This works! This fixes the bug, I tested it with myself and an alt account on my own world. Thank you so much! |
How do I exactly do that? I'm new here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return 0 instead of throw when unknown
Closes minecraft-linux/mcpelauncher-manifest#830
Closes minecraft-linux/mcpelauncher-manifest#832
I don't think it's good to crash when the type is unknown. It could probably be abused if the port it is listening on is forwarded.