Repository navigation
Conversation
commit: |
This was referenced Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An async CLI calling a local
useTerminal()utility receives a hook-order warning because the import starts withuse. The utility allocates a port, launches a process and logs its output.What changed
Recognize a bounded CommonJS utility shape from its complete local implementation and declared Node API roles. Require the exact JavaScript provider and closed bindings, callbacks and supported native operations.
Keep warnings for React hooks, unknown providers, mutable bindings, alternate loaders and unsupported resolution. Record provider, manifest and configuration dependencies through the same rule predicate. Reuse the provider traversal and identifier lookups, and dispatch validation by AST kind while preserving validator bodies and dependency-probe behavior.
Add synthetic regressions, a fuzz fixture and a patch changeset. This PR stacks on #2190.
Test plan and results
Current commit:
b41daa82337c28a31503cf051fbeef8b03e81af9.Performance validation in progress
Current commit
b41daa82337c28a31503cf051fbeef8b03e81af9completed the frozen first-two isolated default-pool comparisons against the original2d11cfdbase. Activation and timing both preserved the expected 128 warnings → 0, with full diagnostic records retained. The timing case used five samples and one warmup per cache cohort, with the original thresholds unchanged.Both cache cohorts pass the frozen first128 wall, CPU and RSS criteria. The wall comparison uses the existing sum-of-MAD noise heuristic, not a confidence interval. RSS measures the maximum single process, not concurrent aggregate memory. Dedicated CPU profiles use a separate explicit child process; hot rule-time attribution is unavailable. Three freshly built Linux runtimes, all raw results and exact cleanup receipts were retained and independently checked.
The next frozen capture completed 35 additional activation comparisons, preserving all 140 expected records, before the command response stream ended unexpectedly. The following activation comparison has one completed base warmup and a cancelled head warmup; neither receives completed-comparison credit. Its raw results, command interruption and cleanup records remain preserved.
117 comparisons still require completion, including that partial activation case. All six remaining timing workloads are unstarted. The continuation keeps the original schedule, including the general control’s nine timing samples, and excludes the first two and all 35 completed activation comparisons. Command transport validation and resource checks must pass before it starts; no completed timing result is being retried.
The previous commit
7df004eb61d75afbaf1eefc2f3de8955e10b0b78reached the first128 barrier and stopped on a flag. A run-directory mismatch prevented raw-data retrieval before sandbox cleanup. Its detailed metrics and profiles are unavailable, so the triggering criterion and size cannot be independently checked.The earlier commit
ffb04463a1851ea7bed285dde5918ef3a650a4bfrecorded cold CPU increasing from 2.11s to 2.48s (+17.54%), above the 10% review threshold. Its cold wall median fell from 1,222.48ms to 1,186.76ms; maximum single-process RSS increased 9.17%. Hot CPU improved from 1.51s to 1.19s. Those measurements belong to that earlier source and remain preserved, along with the earlier repository-level wall-time flag.This PR remains a draft pending the remaining performance comparisons and incomplete parity pairs. The new first-two result does not waive historical flags or establish readiness.