Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
aidenybai
marked this pull request as ready for review
October 20, 2026 09:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A caller and its immediately invoked helper can test the same readonly React ref with opposite truthiness. The helper’s side-effect branch is then unreachable, including when React replays the updater, but the existing analysis still reported that branch.
What changed
Carry the bounded immediate ref-guard exclusion through supported updater entry points. Keep mutations, escapes, unsupported consumers, and conflicting entry paths reporting. Independent review preserved the proof boundaries and corrected runtime value lookup through erased TypeScript declarations, adding an erased-ref regression, a valid runtime export control, a synthetic fuzz regression, and a generator control. Published behavior has patch Changesets.
Existing author fixture and snippet literal values and order remain intact. The HostedCart CLI regression now runs its two scenarios as independent cases, retaining every comparison and assertion with the existing 30-second test budget.
Validation
export =and named-export sample produces TS2309 on both revisions. That diagnostic remains exact and receives no quiet-control credit. A separate valid export-assignment control remains at three target and two other warnings with no parser diagnostic.exhaustive-depswarning, while the six other diagnostic objects and full CLI identities remain exact. This additional removal follows the existing nativeuseRefstability classification.Remote parity is blocked by missing Vercel Sandbox authentication, team/org, and project environment variables. No remote corpus, performance, or React mount result is claimed.