Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 19, 2026 09:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize paired native media-query listeners when a class constructs one stable matcher record and iterates it with the same handler during mount and unmount. Record replacement, mutation, escape, mismatched handlers, partial cleanup, and visible provider changes retain the warning.
The corrective update checks selected runtime identifiers before relying on scope reference descriptors. Catch-binding defaults and computed expressions can contain runtime references that the scope index omits. Those missing references now decline the collection exemption. Binding names, erased TypeScript positions, and static property names remain distinct from runtime values; shorthand property values receive the runtime check. The shared scope analyzer stays unchanged.
Synthetic regressions cover catch-binding defaults, erased declarations, runtime provider replacement, and shorthand values. The proof remains limited to supported collection syntax under ordinary provider behavior. It does not establish arbitrary aliases, opaque mutations, or dynamically generated code safe. A harmless unsupported form may conservatively retain a warning.
Validation on the corrective files:
The eight-input corrective source comparison restores warnings in four synthetic provider-replacement controls. The nominal pair and complete component source remain quiet. The existing direct-provider warning remains exact. A harmless local-shadow control also returns to the unsupported warning boundary; this is a conservative precision loss, not a demonstrated leak.
The separate built-CLI comparison validates the complete PR against main, using all seven synthetic files and the same target-only configuration. Warnings change 7→6: only the nominal false positive is removed, and the six other whole diagnostic objects remain exact. Both schemaVersion 3 reports cover every file, with no skipped checks and null scores. This main comparison is separate from the corrective source comparison against the previous PR head.
All seven source CI matrix jobs passed for the current head. Five matrix jobs passed 34,268 tests with 1,118 skipped. Node 20 passed 34,265 with 1,121 skipped. Windows passed 34,201 with 1,185 skipped. The twenty-five provider-reference assertions passed on every platform. Packed-install smoke passed on Linux and Windows. Conditional steps and test-task cache reuse remain recorded in the CI logs.
The full-rule sample completed across twenty roots from six repositories and analyzed 1,721 files. All 3,308 diagnostic objects retain their exact content and order in both aggregate and project reports. Every other typed report field is exact except twenty producer commit stamps and forty timing values. The target rule reports zero findings in both runs, so the sample does not establish activation of the collection proof.
Earlier-head comparisons remain historical. These results cover only the measured source, synthetic CLI, and finite sample behavior. They do not close the general mechanism or family. Full-corpus validation remains blocked, and performance remains unmeasured. Historical raw-model evidence remains unavailable and unwaived.