Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 18, 2026 22:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A closed native listener can own finite coordinate state without forwarding each update through a React event handler. The rule now preserves that narrow pattern while continuing to report React writers and unsupported listener flows.
The review also found that erased TypeScript interfaces could hide native
document, a selected setter, or the React namespace. Those declarations must not change runtime binding recognition.What changed
Test plan
FUZZ_REQUIRE_FIRE=1. Numeric iteration/fire statistics were not emitted.pr-2126-local-proof.json,pr-2126-lower-independent-source-review.json,pr-2126-lower-sibling-delta-review.json.Official remote parity could not run: Vercel token/OIDC, team/project credentials, and the sister React Doctor Evals checkout are absent. These synthetic comparisons do not claim real OSS coverage or official parity.
Reviewed with independent Codex assistance.