Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 18, 2026 14:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A fixed set of editable text positions can keep position keys when every supported edit preserves those positions. TypeScript-only names must not make a valid editor warn or hide state writes from the detector.
What changed
Test plan
no-array-index-as-keyandno-direct-state-mutation, with 500 configured iterations, seed 42 and required target liveness. Numeric statistics were not emitted; these runs do not establish coverage of each new fixture.Built API/CLI comparisons used separate unchanged projects with 84 original contexts and six new data contexts. Across default plus explicit target opt-in and targeted profiles, primary warnings changed from 73 to 74 in the first project and from three to four in the second. These changes remove erased-hook false positives and restore closed-grammar warnings; the nonempty same-length reset is not certified as a runtime true positive. All retained diagnostic objects, ordering and CLI identities matched exactly; targeted profiles had no unrelated findings.
Default nonprimary findings changed from six to seven and from three to six, solely through four restored
no-direct-state-mutationfindings on the erased reverse fixtures. These have focused and corpus coverage. The comparisons used controlled React 19.2.6 metadata without Preact; one authored unit case uses explicit Preact capabilities, so its unit and public outcomes differ. These checks do not establish Preact runtime compatibility.The staged scan covered 16 code files in 17 repair paths and reported five expected warnings in intentional failure fixtures. Its warning-blocking exit code was one; it reported unknown framework and no React detection, so it is not target-activation or clean-scan evidence.
Remote parity has not run:
VERCEL_OIDC_TOKENorVERCEL_TOKEN,VERCEL_TEAM_ID/VERCEL_ORG_ID, andVERCEL_PROJECT_IDare unavailable. The in-repository evaluator is present; the separate local RDE checkout is unavailable. No remote or local evaluation was attempted.