Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 23:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webhook-signature-riskcurrently warns on a closed Shopify SDK handler even when it awaitswebhooks.validate, rejects an invalid result, and checks success before acting on the raw webhook body. Recognize that finite gate for an inlineshopifyApiclient or one default import from an explicit relative.js/.mjsprovider. Keep warnings for ignored results, changed bodies or results, provider mutation, and unsupported handler shapes.The review also bounds repeated readonly-reference and header-prefix proofs. Only immutable reference-flag eligibility is memoized by the actual scope analysis and symbol; depth, cycle, import permissions and provider-file reads stay fresh. Exact validated
request.headersnodes use identity membership. Durable work and context regressions cover both admitted 20/100 shapes and provider edits, removal, restoration and symlinks.This recognizes an obvious validation step under the ordinary SDK/module assumptions. It does not enforce an installed SDK version or certify cryptographic correctness, raw-byte middleware, replay protection or end-to-end security. The synthetic profile uses SDK 13.0.0; the official 13.1.0 changelog separately reports a webhook-HMAC fix. The conservative TypeScript boundary applies to reached TS-prefixed/declare nodes; JS-shaped
.tsfiles and erased parameter annotations can still match.Validation passed on the frozen final tree: 56 focused tests; all 12 test tasks with 34,122 passes and 1,118 skips; all 10 typecheck tasks; and a fresh five-task build, each graph without cache. Lint, formatting, registry generation, the two actual corpus loader/scan verdicts and built JSON smoke passed. Strict fuzzing ran once with 500 iterations, seed 42 and required positive target fire, with no findings.
Independent actual security-scan and API/CLI comparisons preserve all finding fields, order and multiplicity: 45 scenarios/87 source files with 40 target findings, and the expanded 55-scenario/97-source union with 45 target findings. All four profiles explicitly retain ordinary rules; the one unrelated default
no-evalfinding is unchanged. Nine actual API/CLI provider lifecycle states preserve same-host warm/cold results. These are project-level security-scan witnesses, not ordinary AST-plugin lint runs. Staged/diff scans skip this security scan; active target behavior is established by the whole-project profiles. Fresh credentialed sandbox parity is unavailable.The existing patch Changeset covers the three published packages. No canonical resolver dependency, merge, release tag or publishing action is included.