Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 19:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static array/object initializers that invoke a value-imported function must keep their render-time evaluation. The rule conservatively withholds module-scope hoist advice for a nonoptional bare imported call, including a closed readonly const alias chain.
This review fixes erased TypeScript declarations masking actual imported readers and destructuring assignments masking alias writes. Immutable readonly/origin caches avoid rescanning the same imported references and alias chains while preserving declaration order at every use and initializer link. Existing authored main-rule logic and source-presence exclusions remain intact.
The rule remains disabled by default. Pure or dead imported calls can deliberately withhold advice; imported-function purity is not inferred. Namespace/member/optional calls, constructors, tagged templates and type-only imports stay outside this route.
Validation on tested tree
ea6611314429a25465e2a7734c716b1a617d0b4e:FUZZ_REQUIRE_FIRE=1. Numeric counters are not available from the test wrapper; this is the positive-liveness gate.customRulesOnly: false. The target-only and other-default-rules profiles complete all files; unconfigured-default behavior was not measured.Cold deterministic 20/100 probes retain quiet admission and warning controls: direct imported-reference visits fall from 400/10,000 to 20/100, and deep alias-reference visits from 780/19,900 to 39/199. These are work counts, not timing measurements.
Fresh full sandbox/corpus parity remains unavailable without credentials. The bounded synthetic comparisons do not establish full-corpus parity. Patch Changesets are included. No merge or release is requested.