Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 18:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A readonly uppercase local navigation helper used exclusively by a closed native form submit handler runs from the event path. Preserve that distinction while retaining warnings for render-time calls, escaped helpers, and source-visible provider replacement.
What changed
Recognize the finite direct-const helper, single synchronous handler, authoritative native
form onSubmit, and returned native-container/fragment path. Unsupported transport, custom JSX pragmas, ambiguous ownership, rebindings, and runtime TypeScript still decline the certificate. The shared render classifier remains unchanged.Preserve runtime bindings across inert type declarations, decline source-visible selected router-provider writes and opaque namespace escapes, and reuse immutable program/reference/JSX/source-string facts. Keep
getTextbound and fresh, with owner, caller, handler, and ancestry checks specific to each occurrence. The host source object is forwarded unchanged.The latest fixture-only commit replaces five unused named React
Fragmentimports with React side-effect imports. All other tracked files and all fixture metadata, verdicts, and remaining source bytes are unchanged. Runtime/source maps match the previously reviewed implementation exactly.Validation
For current head
fc973b00and treeafb5fdf8:Historical implementation validation belongs to head
4142f39a, treeb88e283b: all 12 test tasks and 10 typecheck tasks ran uncached, with 34,264 passed and 1,118 skipped tests. Strict 500-iteration seed-42 target fuzz ran once withFUZZ_REQUIRE_FIRE=1; its firing assertion passed, with no numeric statistics or repeat run claimed. The original 46-file base and 75-file union native/API/CLI comparisons, source-context/receiver checks, JSX-curly compatibility controls, and normal-hook proof remain historical evidence for the identical runtime. The current fixture revision did not rerun that full local test graph or the 75-file matrix.The original 42 authored controls contain one strict ES-module parser rejection: an ambient
evalbinding at line 1, column 15. Its native silence earns no precision credit. The 41 valid authored controls retain all full diagnostic objects except the reviewed safe outer-helper/inert-interface correction. Additional binding/provider changes are explicit; ordinary React/router behavior remains an assumption.Fresh full sandbox parity did not run because the required Vercel token/OIDC plus team/org and project credentials are absent; the original Daytona credential is absent too. No merge or release is requested.