Skip to content

FPFNFIXAPEX: recognize closed native submit helper navigation - #2096

Open
aidenybai wants to merge 3 commits into
mainfrom
codex/native-submit-helper-event-proof
Open

aidenybai wants to merge 3 commits into
mainfrom
codex/native-submit-helper-event-proof

Conversation

@aidenybai

@aidenybai aidenybai commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Why

A readonly uppercase local navigation helper used exclusively by a closed native form submit handler runs from the event path. Preserve that distinction while retaining warnings for render-time calls, escaped helpers, and source-visible provider replacement.

What changed

Recognize the finite direct-const helper, single synchronous handler, authoritative native form onSubmit, and returned native-container/fragment path. Unsupported transport, custom JSX pragmas, ambiguous ownership, rebindings, and runtime TypeScript still decline the certificate. The shared render classifier remains unchanged.

Preserve runtime bindings across inert type declarations, decline source-visible selected router-provider writes and opaque namespace escapes, and reuse immutable program/reference/JSX/source-string facts. Keep getText bound and fresh, with owner, caller, handler, and ancestry checks specific to each occurrence. The host source object is forwarded unchanged.

The latest fixture-only commit replaces five unused named React Fragment imports with React side-effect imports. All other tracked files and all fixture metadata, verdicts, and remaining source bytes are unchanged. Runtime/source maps match the previously reviewed implementation exactly.

Validation

For current head fc973b00 and tree afb5fdf8:

  • 360 focused React Router and shared semantic/provider tests passed.
  • 217 fuzz-package tests passed; the 907 random-fuzz tests remained intentionally skipped. Eight actual corpus fixtures load with recognized directives and pass direct replay.
  • All 10 typecheck tasks passed uncached, plus lint, format check, generated-registry freshness, a fresh serial five-task build, and JSON-report smoke.
  • Native and active default/targeted API/CLI comparisons scanned the same eight old/new fixture sources completely. Each has two target diagnostics and zero unrelated diagnostics. Complete objects/order are unchanged except the provider-write fixture's independently derived 18-byte offset reduction; line, column, length, message, identity, and fingerprint remain unchanged.
  • All executable build artifacts match the prior finalized build. The sole declaration-file difference is equivalent ordering of a literal union.

Historical implementation validation belongs to head 4142f39a, tree b88e283b: all 12 test tasks and 10 typecheck tasks ran uncached, with 34,264 passed and 1,118 skipped tests. Strict 500-iteration seed-42 target fuzz ran once with FUZZ_REQUIRE_FIRE=1; its firing assertion passed, with no numeric statistics or repeat run claimed. The original 46-file base and 75-file union native/API/CLI comparisons, source-context/receiver checks, JSX-curly compatibility controls, and normal-hook proof remain historical evidence for the identical runtime. The current fixture revision did not rerun that full local test graph or the 75-file matrix.

The original 42 authored controls contain one strict ES-module parser rejection: an ambient eval binding at line 1, column 15. Its native silence earns no precision credit. The 41 valid authored controls retain all full diagnostic objects except the reviewed safe outer-helper/inert-interface correction. Additional binding/provider changes are explicit; ordinary React/router behavior remains an assumption.

Fresh full sandbox parity did not run because the required Vercel token/OIDC plus team/org and project credentials are absent; the original Daytona credential is absent too. No merge or release is requested.

@pkg-pr-new

pkg-pr-new Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@2096
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@2096
npm i https://pkg.pr.new/react-doctor@2096

commit: fc973b0

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

Terminal Control verified the built CLI at fc973b0 in a real PTY:

  • selected a project interactively and observed Scanning... before the three-second Git delay completed
  • waited for the clean result and exercised the compact report
  • opened copy context and the GitHub Actions confirmation, then cancelled safely

Download the edited MP4 and PNG evidence

@aidenybai
aidenybai marked this pull request as ready for review October 17, 2026 18:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant