Repository navigation
FP104: keep Pages Router app paths outside App Router rules - #1880
Merged
Merged
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pages Router path such as
pages/app/editor.tsxcontains anappsegment but is not an App Router file. React Doctor treated that segment as an App Router directory and incorrectly rejected a validnext/headimport.When the project root is known, App Router rules now require the file to be under the project’s
app/orsrc/app/directory. The existing shared directory helper supplies the fix to the other App Router rules. Unknown-root fallback and other directory checks keep their existing behavior.New full-corpus audit case FP104-58: mdSilo-web, pages/app/md.tsx:1. Source hashes were verified against the pinned repository. The original detector reproduced the report; the fixed detector emits none.
Validation: 820 focused Next.js, server-fetch, and directory tests passed, including four Pages Router/component negatives that failed before the fix and four actual App Router controls. The full workspace suite, build, lint, typecheck, format check, and JSON report smoke check passed. Includes a synthetic fuzz seed and patch changesets.
Next.js documents next/head for the Pages Router.
Pushed-head corpus comparison
All 49 repositories and 49 roots completed with no skips and no diagnostic changes across the 22 impacted rules. The mdSilo case is outside this 49-repository set; its original and fixed source replays are recorded separately. Evaluation resources were verified deleted.
CI follow-up: the package-gate tests now use their existing probe rule so App Router directory checks are tested separately. Temporary paths are canonical on macOS. All local workspace tests, lint, typecheck, format check, and JSON-report smoke passed after this test-only correction. Detector source is unchanged from the recorded corpus comparison.