Skip to content

fix: support Bun child process channels - #1819

Merged
aidenybai merged 4 commits into
mainfrom
aiden/fix-bun-json-output-877e
Sep 19, 2026
Merged

aidenybai merged 4 commits into
mainfrom
aiden/fix-bun-json-output-877e

Conversation

@aidenybai

@aidenybai aidenybai commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

  • guard child-process IPC ref/unref calls for Bun runtimes whose channel omits those Node methods
  • keep Node behavior unchanged when both methods are available
  • add focused regression coverage for channels with methods, Bun-compatible channels without methods, and absent channels

Closes #1815.

Validation

  • focused core regression: 3 tests passed
  • nr typecheck
  • nr lint
  • nr format:check

Release

Includes a patch changeset for react-doctor. No GitHub Action files or Action release surfaces are changed.

Open in Web Open in Cursor 

cursoragent and others added 2 commits September 19, 2026 10:54
Co-authored-by: aiden <aiden@million.dev>
Co-authored-by: aiden <aiden@million.dev>
@pkg-pr-new

pkg-pr-new Bot commented Sep 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1819
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1819
npm i https://pkg.pr.new/react-doctor@1819

commit: df3d458

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

React Doctor skipped this pull request — it changed no React files.

Reviewed by React Doctor for commit df3d458.

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

Terminal Control verified the built CLI at df3d458 in a real PTY:

  • selected a project interactively and observed Scanning... before the three-second Git delay completed
  • waited for the clean result and exercised the compact report
  • opened copy context and the GitHub Actions confirmation, then cancelled safely

Download the edited MP4 and PNG evidence

cursoragent and others added 2 commits September 19, 2026 10:58
Co-authored-by: aiden <aiden@million.dev>
Co-authored-by: aiden <aiden@million.dev>
@cursor cursor Bot changed the title fix: prevent Bun and Action report failures fix: support Bun child process channels Sep 19, 2026
@aidenybai
aidenybai marked this pull request as ready for review September 19, 2026 17:29
@aidenybai
aidenybai merged commit 260b448 into main Sep 19, 2026
25 of 26 checks passed
@aidenybai
aidenybai deleted the aiden/fix-bun-json-output-877e branch September 19, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI error: child.channel?.unref is not a function. (In 'child.channel?.unref()', 'child.channel?.unref' is undefined)

2 participants