Conversation
Check if channel methods exist before calling them to fix runtime error: "child.channel?.unref is not a function" when running under Bun. Closes #1815 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
skoshx
marked this pull request as ready for review
September 16, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The error "child.channel?.unref is not a function" occurs in
/agent/repos/react-doctor/packages/core/src/utils/set-child-process-ref.ts. The code callschild.channel?.ref()andchild.channel?.unref()assuming that ifchild.channelexists, it will have these methods (standard Node.js IPC channel API).In Bun: The
child.channelproperty exists but doesn't implement theref()/unref()methods, causing the runtime error.Solution
Make the calls defensive by checking if the methods exist before calling them:
This makes the code compatible with both Node.js and Bun runtimes.
Changes
packages/core/src/utils/set-child-process-ref.tsto check if methods exist before callingpackages/core/tests/set-child-process-ref.test.tscovering:Testing
Closes #1815