Conversation
…the native driver Closes #1784 Co-Authored-By: aiden@million.dev <aiden.bai05@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
Original prompt from Aiden
|
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1784.
rn-prefer-reanimatedfired on any value import ofAnimatedfromreact-native, so a file whose only animation wasAnimated.loop(Animated.timing(opacity, { useNativeDriver: true }))was told its animation ran on the JS thread.The rule now defers the
Animatedimport diagnostic toProgram:exitand only drops it when the file has static proof that everything runs natively:Boundaries kept deliberately tight:
timing/spring/decay/eventwith a missing,false, spread, or unresolvableuseNativeDriverstill marks the file JS-threaded, so one native call cannot exempt a JS-driven one in the same file.Animatedbut has no recognized config call keeps the existing import-level heuristic (still reports).LayoutAnimationis unchanged and reports immediately.Reanimated.timing(...)fromreact-native-reanimatedis ignored (receiver must resolve to thereact-nativeexport).Regression tests cover the issue repro, const-object config, aliased import with
spring/event,false/missing driver, mixed native + JS in one file, andLayoutAnimationalongside a nativeAnimated. Changeset added foroxlint-plugin-react-doctor.Link to Devin session: https://app.devin.ai/sessions/3401e96268dc4245bf9a058d631ccc36
Open in Devin Desktop: https://app.devin.ai/desktop/session/3401e96268dc4245bf9a058d631ccc36?variant=devin
Requested by: @aidenybai