feat: update workflows - #91
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
- Added new dependencies for the MCP application, including '@effect/platform-node', '@modelcontextprotocol/sdk', and 'accessibility-checker-engine'. - Updated the publish workflow to include a separate step for publishing the MCP application. - Introduced a detailed prompt for using Expect browser testing tools effectively in the MCP server. - Cleaned up the CLI package.json by removing the 'expect-mcp' entry from the bin section.
- Consolidated the publish step for both CLI and MCP applications into a single job. - Updated output handling to capture URLs for both applications and store them in GitHub Actions output. - Adjusted smoke test commands to reference the new output structure.
- Added a new resource for the Expect MCP Guide, providing users with a reference for using Expect browser testing tools effectively. - Updated descriptions for various MCP commands to include guidance on reading the Expect guide before usage, improving user experience and clarity.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/browser/src/mcp/server.ts">
<violation number="1" location="packages/browser/src/mcp/server.ts:633">
P2: Commenting out `registerRulesResources(server)` removes MCP rule resources and the `rules` prompt from the server.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| }), | ||
| ); | ||
|
|
||
| // registerRulesResources(server); |
Contributor
There was a problem hiding this comment.
P2: Commenting out registerRulesResources(server) removes MCP rule resources and the rules prompt from the server.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/browser/src/mcp/server.ts, line 633:
<comment>Commenting out `registerRulesResources(server)` removes MCP rule resources and the `rules` prompt from the server.</comment>
<file context>
@@ -604,22 +612,25 @@ export const createBrowserMcpServer = <E>(
);
- registerRulesResources(server);
+ // registerRulesResources(server);
return server;
</file context>
- Adjusted the formatting of the options table in the CLI README for better readability. - Ensured consistent spacing and alignment across all option descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a standalone
expect-mcpapp and a built-in "run" prompt with an Expect testing guide. Updates the publish workflow to release the CLI andexpect-mcptogether with separate preview URLs.New Features
apps/mcpwith theexpect-mcpbinary packed viavite-plus(bundles@expect/*, keepsplaywrightexternal).apps/cliandapps/mcpin one job and captures separateexpect-cliandexpect-mcppreview URLs; smoke tests updated.Migration
expect-mcpin itsbin. Use the newexpect-mcppackage instead.Written for commit 28eb432. Summary will update on new commits.