Support $('#main').data('smoothState').reload()#363
Open
Cow258 wants to merge 1 commit into
Open
Conversation
rupl
suggested changes
Jun 7, 2018
| window.location = url; | ||
| } | ||
| }, | ||
| /**Reload the page */ |
There was a problem hiding this comment.
This probably needs a docblock like all the others, just to keep to coding standards.
| setRateLimitRepeatTime(); | ||
|
|
||
| // clear cache | ||
| cache = {}; |
There was a problem hiding this comment.
What if someone's cache has 4 or 5 entries, will this wipe the entire thing? Possible to search for the current location and remove only the one entry?
|
|
||
| // Allows modifications to the request | ||
| request = options.alterRequest(request); | ||
| console.log(request); |
There was a problem hiding this comment.
is this console.log just a leftover debug or intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Reload the page