Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 2, 2026

Fixes #233992

@Tyriar Tyriar added this to the December / January 2026 milestone Jan 2, 2026
@Tyriar Tyriar self-assigned this Jan 2, 2026
Copilot AI review requested due to automatic review settings January 2, 2026 00:18
@Tyriar Tyriar moved this to In Progress in VS Code Editor GPU Renderer Jan 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds strikethrough rendering support to the GPU-accelerated editor renderer. The implementation includes CSS validation for text-decoration properties, decoration style caching for strikethrough attributes, and canvas-based rendering of the strikethrough line.

Key Changes:

  • Added support for text-decoration CSS properties (text-decoration, text-decoration-line, text-decoration-style, text-decoration-color, text-decoration-thickness)
  • Extended decoration style cache to track strikethrough state and thickness
  • Implemented strikethrough rendering in the glyph rasterizer using canvas fillRect

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/vs/editor/browser/gpu/viewGpuContext.ts Added text-decoration CSS properties to supported rules list and implemented validation logic for strikethrough-specific values
src/vs/editor/browser/gpu/renderStrategy/viewportRenderStrategy.ts Added strikethrough and strikethroughThickness variables, parsing logic for text-decoration properties, and updated cache entry creation
src/vs/editor/browser/gpu/renderStrategy/fullFileRenderStrategy.ts Applied same strikethrough handling as viewport strategy to maintain consistency between render strategies
src/vs/editor/browser/gpu/raster/glyphRasterizer.ts Implemented canvas-based strikethrough rendering with positioning and thickness calculations
src/vs/editor/browser/gpu/css/decorationStyleCache.ts Extended interface and cache implementation to include strikethrough and strikethroughThickness properties

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

@Tyriar Tyriar moved this from In Progress to In Review in VS Code Editor GPU Renderer Jan 2, 2026
@Tyriar Tyriar marked this pull request as ready for review January 2, 2026 13:44
@Tyriar Tyriar enabled auto-merge January 2, 2026 13:44
@Tyriar Tyriar merged commit 13b4066 into main Jan 2, 2026
28 checks passed
@Tyriar Tyriar deleted the tyriar/233992 branch January 2, 2026 14:53
@github-project-automation github-project-automation bot moved this from In Review to Done in VS Code Editor GPU Renderer Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Editor GPU: Render deprecated strikethrough decorations on the GPU

3 participants