Skip to content

Merge latest Library.Template updates - #1567

Merged
Andrew Arnott (AArnott) merged 74 commits into
mainfrom
dev/andarno/libtemplateUpdate
Oct 15, 2026
Merged

Andrew Arnott (AArnott) merged 74 commits into
mainfrom
dev/andarno/libtemplateUpdate

Conversation

@AArnott

Copy link
Copy Markdown
Member

Summary

Synchronize StreamJsonRpc with the latest microbuild branch of Library.Template to pick up current build, CI, package, documentation, and tooling improvements.

The merge preserves this repository's README, xUnit v3/Microsoft.Testing.Platform workflow, and existing NativeAOT compatibility traversal. The template's separate full-library NativeAOT check and NativeAOT test-discovery path were intentionally omitted; the existing NativeAOTCompatibility.Test continues to provide the repository's NativeAOT validation.

Validation

  • dotnet restore
  • dotnet build
  • Release CI build and publish: dotnet build tools/dirs.proj -t:build,pack,publish --no-restore -c Release -warnAsError -warnNotAsError:NU1901,NU1902,NU1903,NU1904,LOCTASK002 (run after initializing Visual Studio native tools with vs)
  • tools/dotnet-test-cloud.ps1 -Configuration Release (9,363 passed, 62 skipped, 0 failed)

renovate Bot and others added 30 commits September 10, 2026 20:27
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2 (567)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (568)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is so that if xunit.v3.mtp-v2 wants an older version of it, we use the later version that's consistent with the MTP extension packages
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is so that if xunit.v3.mtp-v2 wants an older version of it, we use the later version that's consistent with the MTP extension packages
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (575)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Avoid re-installing .NET SDK or runtimes
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Re-running a failed docs deployment failed because the prior attempt's
github-pages artifact remained, making deploy-pages find two artifacts.
Use a per-attempt artifact name, and allow workflow_dispatch.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Andrew Arnott (AArnott) and others added 16 commits October 7, 2026 07:17
…lls (593)

Machine-wide installs checked for already-installed SDKs and runtimes under the
native Program Files dotnet directory regardless of the process architecture.
In x86 PowerShell on x64 Windows, or x64 PowerShell on ARM64 Windows, that is
the wrong root, so missing components could be skipped. Select the root where
each architecture's installer actually puts them.
CFSClean2 is included by default (at least for some pipelines) but CFSClean is *not* and we're getting compliance issues filed because nuget.org is reached.
Adding CFSClean explicitly solves it.
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pass the tree-node filter as a single option argument for managed and NativeAOT test runs to avoid platform-specific argument parsing failures.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Resolve template conflicts while preserving the repository README, xUnit/MTP test configuration, and existing NativeAOT traversal. Drop the new full-library NativeAOT check and retain the existing compatibility project.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@AArnott
Andrew Arnott (AArnott) marked this pull request as ready for review October 14, 2026 22:16
Copilot AI balanced review requested due to automatic review settings October 14, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build-only condition mishandles false values, and the imported validator performs destructive cleanup before calling a missing script.

3 open findings
What changed in this PR

Synchronizes StreamJsonRpc with Library.Template’s build and tooling updates while preserving its xUnit workflow and existing NativeAOT validation.

Changes:

  • Adds OIDC feed authentication and configuration tests.
  • Updates build traversal, test automation, dependencies, and CI settings.
  • Refreshes contributor documentation and agent guidance.
File Description
version.json Updates schema URL.
tools/​Validate-TemplateExpansion.ps1 Adds template expansion validator.
tools/​tests/​DocsFeedCredentials.Tests.ps1 Tests feed credential setup.
tools/​tests/​Configure-GitHubOidc.Tests.ps1 Tests OIDC configuration behavior.
tools/​Install-DotNetSdk.ps1 Skips already-installed SDKs and runtimes.
tools/​dotnet-test-cloud.ps1 Improves filtering and log isolation.
tools/​dirs.proj Uses relative traversal references.
tools/​Configure-GitHubOidc.ps1 Configures federated OIDC trust.
test/​dirs.proj Removes whitespace; preserves NativeAOT traversal.
test/​Directory.Build.targets Adjusts app-host and runner configuration.
test/​Directory.Build.props Sets managed test defaults.
test/​AOT.props Refines NativeAOT publishing properties.
init.ps1 Restores through the tools traversal.
Directory.Packages.props Updates testing dependencies.
Directory.Build.props Adjusts publishing property propagation.
CONTRIBUTING.md Documents testing and feed authentication.
azure-pipelines/​vs-validation.yml Updates network isolation policies.
azure-pipelines/​vs-insertion.yml Updates network isolation policies.
azure-pipelines/​unofficial.yml Updates network isolation policies.
azure-pipelines/​release.yml Updates network isolation policies.
azure-pipelines/​official.yml Updates network isolation policies.
azure-pipelines/​libtemplate-update.yml Updates network isolation policies.
azure-pipelines/​dotnet.yml Separates publishing from build-only runs.
azure-pipelines/​build.yml Updates default Linux image.
azure-pipelines/​archive-sourcecode.yml Updates network isolation policies.
AGENTS.md Removes embedded testing guidance; clarifies documentation scope.
.github/​workflows/​libtemplate-update.yml Pins Ubuntu runner image.
.github/​workflows/​docs.yml Adds manual runs and unique deployment artifacts.
.github/​workflows/​docs_validate.yml Adds authenticated feed access.
.github/​workflows/​copilot-setup-steps.yml Adds authentication and updates runner image.
.github/​renovate.json Adds dependency grouping and filtering.
.github/​actions/​publish-artifacts/​action.yaml Updates artifact upload action.
.config/​dotnet-tools.json Updates development tools.
.agents/​skills/​update-library-template/​template-release-notes.md Adds migration and compatibility guidance.
.agents/​skills/​update-library-template/​SKILL.md Expands downstream merge guidance.
.agents/​skills/​testing/​SKILL.md Adds standalone testing guidance.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/Validate-TemplateExpansion.ps1 Resolved
Comment thread azure-pipelines/dotnet.yml Resolved
Comment thread .agents/skills/testing/SKILL.md Resolved
Remove the template-only expansion validator and document the retained xUnit v3 MTP runner, supported filters, and project-specific test commands.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

OIDC trust and cross-platform publishing need human validation, and the runtime servicing regression remains unresolved.

0 open findings

3 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Prerequisite checks skip runtime servicing upgrades

tools/​Install-DotNetSdk.ps1:222

Runtime requests collected above contain only major/minor versions, so this check accepts any installed patch (for example, 8.0.0 for 8.0) and skips the installer. Previously, installation resolved the latest channel patch. This prevents subsequent setup runs—even init.ps1 -UpgradePrerequisites—from installing newer runtime servicing and security fixes. Add an explicit upgrade option, forward UpgradePrerequisites from init.ps1, and bypass the installed-component checks when that option is enabled.

🧠 Review effort: Balanced

@AArnott
Andrew Arnott (AArnott) merged commit f461707 into main Oct 15, 2026
11 checks passed
@AArnott
Andrew Arnott (AArnott) deleted the dev/andarno/libtemplateUpdate branch October 15, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants