Skip to content

Conversation

Copy link

Copilot AI commented Dec 29, 2025

📥 Pull Request

❓ What are you trying to address

Documentation examples for fabric_shortcut resource incorrectly used find/subfind instead of the actual field names path/subpath, preventing users from using the examples successfully.

✨ Description of new changes

  • Updated example source: Corrected field names in examples/resources/fabric_shortcut/resource.tf
    • findpath (7 instances across all resource examples)
    • subfindsubpath (6 instances across adls_gen2, amazon_s3, google_cloud_storage, s3_compatible, dataverse, azure_blob_storage targets)

All seven example configurations (onelake, adls_gen2, amazon_s3, google_cloud_storage, s3_compatible, dataverse, azure_blob_storage) now use correct schema field names.

The auto-generated documentation in the docs folder will be regenerated automatically by the CI pipeline when this PR is merged.

☑️ PR Checklist

  • Link to the issue you are addressing is included above
  • Ensure the PR description clearly describes the feature you're adding and any known limitations

☑️ Resources / Data Sources Checklist

PRs for new/enhanced resources or data sources are expected to meet the following criteria:

Original prompt

This section details on the original issue you should resolve

<issue_title>[DOCS] Error in examples in fabric_shortcut (Resource)</issue_title>
<issue_description>### 📝 Description

In the fabric_shortcut (Resource) documentation, in the Example usage pan, the path word has been replaced by the find word.

📎 Additional context

Replace:

# Example of using the fabric_shortcut resource
resource "fabric_shortcut" "onelake" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    onelake = {
      workspace_id = "00000000-0000-0000-0000-000000000000"
      item_id      = "00000000-0000-0000-0000-000000000000"
      find         = "MyTargetPath"
    }
  }
}

resource "fabric_shortcut" "adls_gen2" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    adls_gen2 = {
      location      = "MyLocation"
      subfind       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "amazon_s3" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    amazon_s3 = {
      location      = "MyLocation"
      subfind       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "google_cloud_storage" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    google_cloud_storage = {
      location      = "MyLocation"
      subfind       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "s3_compatible" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    s3_compatible = {
      location      = "MyLocation"
      bucket        = "MyBucket"
      subfind       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "dataverse" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    dataverse = {
      table_name         = "MyTableName"
      deltalake_folder   = "MyDeltaLakeFolder"
      environment_domain = "MyEnvironmentDomainURI"
      bucket             = "MyBucket"
      subfind            = "MySubpath"
      connection_id      = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "azure_blob_storage" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  find         = "MyShortcutPath"
  target = {
    azure_blob_storage = {
      location      = "MyLocation"
      subfind       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }


  }
}

by

# Example of using the fabric_shortcut resource
resource "fabric_shortcut" "onelake" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  path         = "MyShortcutPath"
  target = {
    onelake = {
      workspace_id = "00000000-0000-0000-0000-000000000000"
      item_id      = "00000000-0000-0000-0000-000000000000"
      path         = "MyTargetPath"
    }
  }
}

resource "fabric_shortcut" "adls_gen2" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  path         = "MyShortcutPath"
  target = {
    adls_gen2 = {
      location      = "MyLocation"
      subpath       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "amazon_s3" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
  path         = "MyShortcutPath"
  target = {
    amazon_s3 = {
      location      = "MyLocation"
      subpath       = "MySubpath"
      connection_id = "00000000-0000-0000-0000-000000000000"
    }
  }
}

resource "fabric_shortcut" "google_cloud_storage" {
  workspace_id = "00000000-0000-0000-0000-000000000000"
  item_id      = "00000000-0000-0000-0000-000000000000"
  name         = "MyShortcutName"
 ...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes microsoft/terraform-provider-fabric#785

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/terraform-provider-fabric/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix examples in fabric_shortcut documentation Fix incorrect field names in fabric_shortcut documentation examples Dec 29, 2025
Copilot AI requested a review from badeamarjieh December 29, 2025 13:20
@badeamarjieh
Copy link
Member

@copilot undo all changes in docs folder, keep only the one in examples

Copy link
Author

Copilot AI commented Dec 29, 2025

@copilot undo all changes in docs folder, keep only the one in examples

Done. Reverted all changes in the docs folder and kept only the changes in examples/resources/fabric_shortcut/resource.tf (commit 514466d).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants