-
Notifications
You must be signed in to change notification settings - Fork 16
feat(domain): use non preview domains API #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(domain): use non preview domains API #676
Conversation
🛑 Changelog entry required to mergeRun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Migrates the domain service from preview APIs to stable APIs by removing "Preview" from type names and method calls throughout the codebase.
- Replaces
DomainPreviewtypes and*Previewmethod calls with non-preview equivalents - Updates schema to replace
contributors_scopefield withdefault_label_idfield - Changes
IsPreviewflag fromtruetofalsein domain type info
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/testhelp/fakes/fabric_domain.go | Updates fake server implementation to use non-preview domain types and methods |
| internal/services/domain/schema.go | Replaces contributors_scope field with default_label_id and removes validation conflicts |
| internal/services/domain/resource_domain_test.go | Updates test assertions to check default_label_id instead of contributors_scope |
| internal/services/domain/resource_domain.go | Replaces preview API calls with stable API equivalents |
| internal/services/domain/models.go | Updates model structs to use Domain instead of DomainPreview types |
| internal/services/domain/data_domains.go | Updates data source to use stable list domains API |
| internal/services/domain/data_domain_test.go | Updates test to check default_label_id attribute |
| internal/services/domain/data_domain.go | Updates data source to use stable get domain API |
| internal/services/domain/base.go | Sets IsPreview flag to false |
| examples/resources/fabric_domain/resource.tf | Adds example showing default_label_id usage |
| docs/resources/domain.md | Removes preview warnings and updates field documentation |
| docs/data-sources/domains.md | Removes preview warnings and updates field documentation |
| docs/data-sources/domain.md | Removes preview warnings and updates field documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Per my understanding, there are currently two endpoints to list domains: AFAIK the only difference is the permissions required. The core is more lenient since it requires Maybe that would make sense to be able to configure which one to use? |
📥 Pull Request
❓ What are you trying to address
Use the on preview models and methods from the sdk for domain data source and resource