Skip to content

Conversation

@catalina-gav
Copy link
Contributor

📥 Pull Request

Close #626
Close #625

❓ What are you trying to address

Onboard new fabric_mirrored_azure_databricks_catalog data source and resource

Copilot AI review requested due to automatic review settings August 29, 2025 16:55
@catalina-gav catalina-gav requested a review from a team as a code owner August 29, 2025 16:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR onboards a new mirrored Azure Databricks catalog feature by implementing both data source and resource support for managing Fabric Mirrored Azure Databricks Catalogs. The implementation follows the established patterns in the provider and includes comprehensive test coverage and documentation.

  • Adds resource for creating and managing mirrored Azure Databricks catalogs
  • Adds data sources for retrieving single catalogs or lists of catalogs
  • Implements fake server support for testing

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/testhelp/fakes/fake_server.go Registers the new mirrored Azure Databricks catalog entity handler
internal/testhelp/fakes/fabric_mirrored_azure_databricks_catalog.go Implements fake server operations for testing
internal/services/mirroredazuredatabrickscatalog/* Complete service implementation including models, schemas, resources, and data sources
internal/provider/provider.go Registers the new resource and data sources with the provider
examples/* Provides usage examples for both resources and data sources
docs/* Generated documentation for the new features
.changes/* Change log entries for the new features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Changelog Preview

v1.7.1-dev - December 19, 2025

✨ Added

  • #626 Onboard new fabric_mirrored_azure_databricks_catalog Data Source
  • #625 Onboard new fabric_mirrored_azure_databricks_catalog Resource

🪲 Fixed

  • #767 Fix resource fabric_spark_environment_setting update pool not working

@catalina-gav catalina-gav changed the title feat(warehouse_snapshot): onboard new mirrored azure databricks catalog DS and RS feat(mirrored_azure_databricks_catalog): onboard new mirrored azure databricks catalog DS and RS Sep 1, 2025
func() datasource.DataSource {
return mirroredazuredatabrickscatalog.NewDataSourceMirroredAzureDatabricksCatalog(ctx)
},
func() datasource.DataSource {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make each entry a single line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how the formatting is enforced upon saving the file and i dont think it can be bypassed

// },
// ),
// Check: resource.ComposeAggregateTestCheckFunc(
// resource.TestCheckResourceAttr(testDataSourceItemFQN, "workspace_id", workspaceID),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this getDefinition is currently not working from the API's side for items that have been created without a definition (fails with Resource NotFound error message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DS] Add Mirrored Azure Databricks Catalog data source [RS] Add Mirrored Azure Databricks Catalog resource

4 participants