-
Notifications
You must be signed in to change notification settings - Fork 16
feat(mirrored_azure_databricks_catalog): onboard new mirrored azure databricks catalog DS and RS #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(mirrored_azure_databricks_catalog): onboard new mirrored azure databricks catalog DS and RS #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR onboards a new mirrored Azure Databricks catalog feature by implementing both data source and resource support for managing Fabric Mirrored Azure Databricks Catalogs. The implementation follows the established patterns in the provider and includes comprehensive test coverage and documentation.
- Adds resource for creating and managing mirrored Azure Databricks catalogs
- Adds data sources for retrieving single catalogs or lists of catalogs
- Implements fake server support for testing
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testhelp/fakes/fake_server.go | Registers the new mirrored Azure Databricks catalog entity handler |
| internal/testhelp/fakes/fabric_mirrored_azure_databricks_catalog.go | Implements fake server operations for testing |
| internal/services/mirroredazuredatabrickscatalog/* | Complete service implementation including models, schemas, resources, and data sources |
| internal/provider/provider.go | Registers the new resource and data sources with the provider |
| examples/* | Provides usage examples for both resources and data sources |
| docs/* | Generated documentation for the new features |
| .changes/* | Change log entries for the new features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
examples/data-sources/fabric_mirrored_azure_databricks_catalog/data-source.tf
Outdated
Show resolved
Hide resolved
examples/resources/fabric_mirrored_azure_databricks_catalog/resource.tf
Outdated
Show resolved
Hide resolved
| func() datasource.DataSource { | ||
| return mirroredazuredatabrickscatalog.NewDataSourceMirroredAzureDatabricksCatalog(ctx) | ||
| }, | ||
| func() datasource.DataSource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make each entry a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is how the formatting is enforced upon saving the file and i dont think it can be bypassed
| // }, | ||
| // ), | ||
| // Check: resource.ComposeAggregateTestCheckFunc( | ||
| // resource.TestCheckResourceAttr(testDataSourceItemFQN, "workspace_id", workspaceID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this getDefinition is currently not working from the API's side for items that have been created without a definition (fails with Resource NotFound error message)
📥 Pull Request
Close #626
Close #625
❓ What are you trying to address
Onboard new fabric_mirrored_azure_databricks_catalog data source and resource