Skip to content

NetworkPkg/UefiPxeBcDxe: Add UDP Completion Tokens to PXEBC_PRIVATE_DATA#1632

Open
makubacki wants to merge 1 commit intomicrosoft:release/202502from
makubacki:networkpkg_uefipxebcdxe_udp_completion_tokens
Open

NetworkPkg/UefiPxeBcDxe: Add UDP Completion Tokens to PXEBC_PRIVATE_DATA#1632
makubacki wants to merge 1 commit intomicrosoft:release/202502from
makubacki:networkpkg_uefipxebcdxe_udp_completion_tokens

Conversation

@makubacki
Copy link
Member

Description

This change tracks UDP completion tokens in the PXEBC_PRIVATE_DATA structure, so they are persisted for cleanup in the Stop function in case it is called while a UDP operation is still pending.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • PXE boot with USB NIC disconnect to trigger EfiPxeBcStop() during UDP read

Integration Instructions

  • N/A

Note: A following PR may apply a similar change to the UDP write functions, but the issue was only observed in the UDP read functions, so this change is applied immediately for the time being.

This change tracks UDP completion tokens in the `PXEBC_PRIVATE_DATA`
structure, so they are persisted for cleanup in the Stop function
in case it is called while a UDP operation is still pending.

Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki self-assigned this Feb 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202502@afb0c81). Learn more about missing BASE report.

Files with missing lines Patch % Lines
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c 0.00% 18 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202502   #1632   +/-   ##
================================================
  Coverage                  ?   0.55%           
================================================
  Files                     ?     165           
  Lines                     ?   71965           
  Branches                  ?    1755           
================================================
  Hits                      ?     402           
  Misses                    ?   71556           
  Partials                  ?       7           
Flag Coverage Δ
NetworkPkg 0.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki makubacki requested review from apop5 and kuqin12 February 6, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants