feat: add hyperVVmId and hostNodeIpAddress to VirtualMachine proto#419
Open
jocardeMSFT wants to merge 1 commit intomainfrom
Open
feat: add hyperVVmId and hostNodeIpAddress to VirtualMachine proto#419jocardeMSFT wants to merge 1 commit intomainfrom
jocardeMSFT wants to merge 1 commit intomainfrom
Conversation
Add fields to the cloudagent VirtualMachine proto so that a single Invoke(GET) can return hyperVVmId and hostNodeIpAddress alongside the existing nodeName, eliminating the need for separate GetHyperVVmId, GetHostNodeName, and GetHostNodeIpAddress RPCs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
niontive
approved these changes
Feb 20, 2026
rbalwani
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem Statement
During every VM reconcile, the moc-operator makes 4 separate gRPC calls (~7 round-trips) to retrieve host info that could be returned in a single enriched VM Get response.
Proposed Solution
hyperVVmId(field 23) andhostNodeIpAddress(field 24) fields to theVirtualMachineprotobuf messageTesting Complete
make generateregenerates protobuf code successfullymake unittestpasses