Skip to content

Update ICU to 78 - Part 3B: generated language data#181

Open
aoruganti-msft wants to merge 1 commit into
user/aoruganti/icu78-data-regionfrom
user/aoruganti/icu78-data-lang
Open

Update ICU to 78 - Part 3B: generated language data#181
aoruganti-msft wants to merge 1 commit into
user/aoruganti/icu78-data-regionfrom
user/aoruganti/icu78-data-lang

Conversation

@aoruganti-msft
Copy link
Copy Markdown
Collaborator

Part 3B of the ICU 78 update split.

This PR is stacked on top of the previous part and contains only generated ICU language data under icu/icu4c/source/data/lang/. It keeps the generated-data review below 300 files; this PR currently changes 229 files.

This is part of bucket 3 from the abandoned combined PR, split by path so reviewers can review generated data in smaller chunks.

Source bucket commits: 93aa833, c061533, a19d44b, ac30408, 99e1d9a.

Copy link
Copy Markdown
Collaborator

@rp9-next rp9-next left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Just double check on deletions once

el{"கிரேக்கம்"}
elx{"எலமைட்"}
en{"ஆங்கிலம்"}
en_AU{"ஆஸ்திரேலிய ஆங்கிலம்"}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted ?
I think it might be needed

Copy link
Copy Markdown
Collaborator Author

@aoruganti-msft aoruganti-msft May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction/clarification: this is not a net-new final-state change from master.

In current master / ICU 72, and in the original monolithic PR #177, the explicit localized regional language entry for en_AU in this file is already absent. It appears as a deletion in the split PR because PR #178 first imports pristine upstream ICU 78 data, which temporarily restores upstream checked-in entries, and this generated-data PR reapplies our generated/MS data state.

So the final stacked result is consistent with master / PR #177 for this entry. Runtime falls back/composes the display name from the base language + region data.

ee{"эве чӗлхи"}
el{"грек чӗлхи"}
en{"акӑлчан чӗлхи"}
en_AU{"австрали акӑлчан чӗлхи"}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it being deleted consitently across all locales..

Wondering why though ?
Looks like only neutrals are kept

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above response for ta.txt.

Split from ICU 78 bucket 3 to keep generated-data review under 300 files.

Source bucket commits: 93aa833, c061533, a19d44b, ac30408, 99e1d9a.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants