feat(docs): enhance CollectionCard with descriptions and progressive disclosure (#1422)#1860
feat(docs): enhance CollectionCard with descriptions and progressive disclosure (#1422)#1860PratikWayase wants to merge 2 commits into
Conversation
bindsi
left a comment
There was a problem hiding this comment.
Automated review (bindsi batch). Well-implemented progressive disclosure enhancement for CollectionCard: adds extendedDescription prop, toggle button with proper aria-expanded/aria-controls, keyboard interaction, and axe accessibility testing for both states. Tests are thorough (collapsed default, toggle behavior, Enter key, a11y for both states). CSS changes are clean. No functional issues. LGTM.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 80.56% 80.55% -0.01%
==========================================
Files 112 112
Lines 18686 18686
==========================================
- Hits 15054 15053 -1
- Misses 3632 3633 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Please ensure you take a look at the branch conflict and the failed check @PratikWayase. Thank you!! |
Pull Request
Description
This PR enhances the
CollectionCardcomponent by introducing richer descriptions and a progressive disclosure pattern.Key improvements:
These changes make the collections section more informative while keeping the UI clean and scalable.
Related Issue(s)
Closes #1422
Type of Change
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
Checklist
Required Checks
Required Automated Checks
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generatenpm run docs:testSecurity Considerations
Before
After