feat(skills): add demo-setup skill to design-thinking collection#1623
feat(skills): add demo-setup skill to design-thinking collection#1623chaosdinosaur wants to merge 17 commits into
Conversation
Closes #1622 Add the demo-setup skill that creates demo-ready prototypes by guiding users through a simulated DT Coach session with a customer persona, then scaffolding a hi-fi prototype via the hifi-prototype skill. Changes: - Add .github/skills/design-thinking/demo-setup/SKILL.md - Add skill entry to collections/design-thinking.collection.yml - Add Skills table to collections/design-thinking.collection.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
==========================================
+ Coverage 82.72% 85.13% +2.41%
==========================================
Files 154 87 -67
Lines 20782 9214 -11568
Branches 13 13
==========================================
- Hits 17191 7844 -9347
+ Misses 3589 1368 -2221
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/review |
|
✅ PR Review completed successfully! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Advisory review — this PR is from a maintainer. Findings are informational only.
Review Summary
The demo-setup skill is well-conceived and the SKILL.md content is thorough and well-structured. The collection YAML and markdown updates follow existing conventions. The two inline comments flag items that need resolution before the PR can pass CI.
🔍 Issue Alignment
✅ Passes. The PR closes #1622 and addresses all stated acceptance criteria in spirit. The hifi-prototype dependency is documented in prose in the PR description and in the SKILL.md Prerequisites and Inputs sections. The issue's AC for "hifi-prototype dependency documented" is satisfied, though adding it to the design-thinking collection in a follow-up would improve discoverability.
⚠️ PR Template Compliance
The PR description does not follow the standard PR template structure (.github/PULL_REQUEST_TEMPLATE.md). Key missing sections:
- Type of Change: No checkboxes checked. The "Copilot skill (
SKILL.md)" box and "New feature" box should be checked. - Sample Prompts: Required for AI artifact contributions. Should show a sample invocation, execution flow, output artifacts, and success indicators.
- AI Artifact Contributions checklist: Boxes for
prompt-builderreview and common standards compliance are not present. - Required Automated Checks checklist:
npm run validate:skillsandnpm run plugin:generateare unchecked in the PR's own validation list — these must pass before merge. - Security Considerations: Section is absent; at minimum the "no sensitive information" checkbox should be confirmed.
⚠️ Code Quality
Missing scripts directory (see inline comment on SKILL.md line 1): Skills require paired .sh and .ps1 scripts. Without them, npm run validate:skills will fail. This is the root cause of the unchecked validation items.
Broken file reference (see inline comment on SKILL.md line 358): The Demo Video Script Template section references demos/contoso/order-intake/demo-video-script.md, which does not exist in the repository.
✅ Coding Standards
The SKILL.md frontmatter is well-formed with name, description, and attribution suffix. Collection YAML uses the correct directory-level path (kind: skill, maturity: preview). The collection markdown table placement (between Chat Agents and Prompts) is appropriate and consistent with the document's structure.
Action Items
- Add
scripts/demo-setup.shandscripts/demo-setup.ps1to the skill directory to satisfyvalidate:skills. - Resolve the broken
demos/contoso/order-intake/demo-video-script.mdreference — either create the file, point to an existing example, or remove the reference. - Confirm
npm run validate:skillsandnpm run plugin:generateboth pass. - Update the PR description to follow the standard template, including Sample Prompts and the AI Artifact checklist.
Remove IFS SmartParts and NYDoc Verify built-in example scenarios from the demo-setup SKILL.md. Demos now run exclusively from user-provided customer, industry, persona, and problem inputs. Commit the demo-video-script-template.md reference file that the skill loads during Step 6.
Move Script Structure, Section Authoring Rules, and Content Derivation tables from demo-setup SKILL.md into references/demo-video-script-template.md to follow progressive disclosure guidance. SKILL.md retains a brief pointer to the template reference.
- Update workflow table Step 1 description to reflect input-driven flow - Point Step 6 directly to references template - Bump last_updated to 2026-05-22
- introduce demo-setup skill for simulating DT Coach sessions - update README and collection files to include demo-setup details - refine demo video script template with new attribution 🤖 - Generated by Copilot
- update input and profile sections for better readability - enhance troubleshooting and validation sections - ensure consistent formatting across all tables 📚 - Generated by Copilot
WilliamBerryiii
left a comment
WilliamBerryiii
left a comment
There was a problem hiding this comment.
Thank you, @chaosdinosaur — this is a really thoughtful addition. Bundling a persona-driven DT Coach simulation, an accelerated Methods 1-6 walkthrough, and a hi-fi scaffold into one repeatable demo flow is exactly the kind of onboarding on-ramp new HVE Core users need, and the presenter's guide plus video script make it genuinely reusable. My comments are about scope and a couple of small consistency items, not the quality of the work. The main thing to sort before merge is the dependency on a hifi-prototype skill that isn't in the repo yet — happy to help shape a proposal for it. Two follow-ups for maintainers: demo-setup still needs registering in collections/design-thinking.collection.yml and .md (then npm run plugin:generate / extension:prepare / extension:prepare:prerelease), and the title-cased Hifi-Prototype references could match the lowercase skill name.
| ## Prerequisites | ||
|
|
||
| * DT Coach agent accessible (provided by the HVE Core extension) | ||
| * hifi-prototype skill accessible (workspace `.github/skills/hifi-prototype/`) |
There was a problem hiding this comment.
This prerequisite points at .github/skills/hifi-prototype/, but skills live under their collection id, so the path should be .github/skills/design-thinking/hifi-prototype/. More importantly, that skill isn't in the repo yet, and Step 4 / Method 7 hard-depends on it — so as written the demo can't complete its scaffold. Rather than block this PR, we should make a proposal for this skill addition: spec and build hifi-prototype as a companion prerequisite to demo-setup. Two of my own migrations are good precedents — #1857 (instruction→skill conversion plus the collection manifest updates) and #1841 (skill-root-relative paths and references/ layout). Happy to pair on the spec.
There was a problem hiding this comment.
Resolved via the decouple path. Step 4 now generates the hi-fi prototype scaffold directly from the inline Demo Scaffold Template, so demo-setup no longer depends on a separate hifi-prototype skill, and the incorrect .github/skills/hifi-prototype/ prerequisite has been removed (commit 28301ac2). A standalone hifi-prototype skill can still be spec'd as a follow-up if we want to reuse Method 7 scaffolding elsewhere — happy to pair on that. Thanks for the precedents (#1857, #1841).
| 7. Apply `[SIMULATED]` badges to all mock components. | ||
| 8. Pre-wire telemetry for page views, clicks, and task timing. | ||
|
|
||
| #### Hifi-Prototype Input Mapping |
There was a problem hiding this comment.
Tiny consistency nit: Hifi-Prototype here (and the reference on line 180) could be lowercased to hifi-prototype to match the actual skill name used elsewhere in the file.
There was a problem hiding this comment.
Fixed in 28301ac2 — the section is now titled Prototype Input Mapping and the title-cased Hifi-Prototype references are gone, so it stays consistent with the lowercase hifi-prototype naming used elsewhere.
| ├── style.css | ||
| ├── app.js | ||
| ├── telemetry.js | ||
| └── sim/fixtures/{domain-data}.js |
There was a problem hiding this comment.
Small encoding artifact: this tree line renders with replacement characters (���──) instead of a box-drawing branch. It should read └── sim/fixtures/{domain-data}.js so the scaffold tree displays correctly.
There was a problem hiding this comment.
Resolved — the scaffold tree now renders as └── sim/fixtures/{domain-data}.js with no replacement characters (verified 0 U+FFFD in the file).
bindsi
left a comment
bindsi
left a comment
There was a problem hiding this comment.
Automated review (bindsi batch). The demo-setup skill SKILL.md is comprehensive and well-structured. The concern raised in prior reviews (WilliamBerryiii, github-actions bot) about unresolved dependencies (hifi-prototype skill not yet in the repo) and missing collection registration remain valid.
No new blocking findings beyond what's already been flagged:
- The
hifi-prototypeskill dependency doesn't exist in the repo yet — this skill cannot fully execute without it. - Collection registration in
design-thinking.collection.ymlis still needed. - The broken file reference to
demos/contoso/order-intake/demo-video-script.md(flagged by the automated review) should be resolved.
Deferring to existing reviewer threads for resolution. No security/correctness issues in the skill specification itself.
bindsi
left a comment
bindsi
left a comment
There was a problem hiding this comment.
Automated batch review: requesting changes for one blocking missing-dependency issue.
…ype dependency The demo-setup skill hard-depended on a hifi-prototype skill that does not exist in the repo, and Method 7 today is documentation-only. Step 4 now generates the hi-fi prototype scaffold directly using the inline Demo Scaffold Template, removing the phantom prerequisite, the incorrect skill path, and the title-cased Hifi-Prototype references.
…p-skill # Conflicts: # collections/hve-core-all.collection.md # collections/hve-core-all.collection.yml # plugins/design-thinking/.github/plugin/plugin.json # plugins/design-thinking/README.md # plugins/hve-core-all/README.md
Eval Execution |
rezatnoMsirhC
left a comment
rezatnoMsirhC
left a comment
There was a problem hiding this comment.
Thank you for this contribution, @chaosdinosaur. The demo-setup skill is well-structured and the decoupling work to remove the hifi-prototype dependency was a clean resolution.
The PR description's Dependencies section still references hifi-prototype as "exists in repo" and as a current dependency. Both are now false since the skill was decoupled in commit 28301ac2. Worth updating so future contributors are not sent looking for a skill that does not exist.
| metadata: | ||
| authors: "microsoft/hve-core" | ||
| spec_version: "1.0" | ||
| last_updated: "2026-05-22" |
There was a problem hiding this comment.
The last_updated field reads 2026-05-22, but the skill was substantially reworked in July 2026 when the hifi-prototype dependency was removed and the scaffold template was inlined. Consider updating this to the date of the final commit before merge.
There was a problem hiding this comment.
Fixed in 3ab7a715 — bumped last_updated to 2026-07-21 so the metadata reflects the July rework (the decouple in 28301ac2 and follow-ups) rather than the original May authoring date. Thanks for the catch.
There was a problem hiding this comment.
Step 2 sets session_mode: demo in coaching-state.md expecting the DT Coach to apply accelerated pacing, and Step 3 depends on that contract for the 2-3 exchanges-per-method flow. Could you add a reference to where this behavior is implemented in the DT Coach agent, so a reader can verify the contract holds? If the DT Coach does not yet recognize this field, this step would be worth flagging as a follow-up dependency rather than presenting it as working behavior.
There was a problem hiding this comment.
Good catch, and you're right to ask for the reference — I verified and the DT Coach does not natively recognize session_mode. The coaching-state.md schema (dt-coaching-foundation/references/coaching-state.md) only defines initial_classification in the project block, and no agent or method instruction branches on session_mode or accelerated pacing.
Fixed in 3ab7a715:
- Step 2 now describes
session_mode: demoas a demo-setup marker that records the session type, not a field the Coach honors. - Step 3 makes explicit that this skill drives the 2-to-3-exchanges-per-method cadence (the Coach does not infer it from
session_mode). - Added a Note under Step 2 and corrected the troubleshooting row that previously implied native recognition.
Formalizing session_mode in the DT Coach agent and the coaching-state schema is called out as a follow-up so the field becomes a real contract if we want it.
Reframe session_mode: demo as a demo-setup convention the DT Coach does not natively recognize; accelerated pacing is enforced by the skill's Step 3 direction. Refresh last_updated and align the troubleshooting row.
|
@rezatnoMsirhC Updated the PR description. The Dependencies section no longer lists |
5 participants
Summary
Add the
demo-setupskill to the design-thinking collection, introducing the first skill artifact in this collection.Closes #1622
Changes
.github/skills/design-thinking/demo-setup/SKILL.md.github/skills/design-thinking/demo-setup/references/demo-video-script-template.mdcollections/design-thinking.collection.ymlkind: skill,maturity: previewcollections/design-thinking.collection.mdcollections/hve-core-all.collection.ymlWhat the Skill Does
Creates demo-ready prototypes by guiding users through a simulated DT Coach session with a customer persona, then scaffolding a hi-fi prototype. The workflow:
The skill is scenario-agnostic — users supply their own domain, persona, and prototype targets as inputs. Primary audience: new users learning HVE Core tools.
Dependencies
Validation Checklist
name,description, and attribution suffixkind: skillentrynpm run validate:skillspasses (demo-setup ✅— 0 errors, 0 warnings)npm run plugin:generatesucceeds (to be verified in CI)