feat: add ADO.NET authentication parameter synonyms#326
Closed
Copilot wants to merge 7 commits into
Closed
Conversation
- Add "authentication" as synonym for "fedauth" in msdsn package - Support ADO.NET authentication value names with spaces in azuread package - Add normalizeAuthenticationMethod to convert ADO.NET names to internal format - Add comprehensive tests for new functionality Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
- Update params map with normalized fedauth value for consistency - Improve comment clarity for "Sql Password" handling Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
- Clarify that empty string return signals non-Azure AD authentication - Explain purpose of updating params map with normalized value Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add more ADO.Net synonyms to connection string parameters
feat: add ADO.NET authentication parameter synonyms
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 79.70% 85.38% +5.67%
==========================================
Files 34 34
Lines 6598 7314 +716
==========================================
+ Hits 5259 6245 +986
+ Misses 1067 816 -251
+ Partials 272 253 -19 🚀 New features to boost your workflow:
|
|
@copilot Re-check this PR using the latest head commit (after merging main) and the newest Actions run. The workflow fix is already in main |
Fixed merge conflict where TestEncodeParametersGetTimezone from main was inserted in the middle of TestAuthenticationSynonym, breaking the test structure. Agent-Logs-Url: https://github.com/microsoft/go-mssqldb/sessions/51bc1a35-124f-4102-a96b-405e5f534ead Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Author
Re-checked the PR after merging with main. Fixed a merge conflict in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan for ADO.NET Authentication Synonyms
Summary
Successfully implemented ADO.NET authentication synonyms and value names. After merging with main, resolved a merge conflict where a new test was inserted in the middle of the TestAuthenticationSynonym test. All tests now pass successfully.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.