Repository navigation
fix(native-core): restore macOS Paper FRNCallout manager alias - #4363
Merged
Saad Najmi (Saadnajmi) merged 1 commit intoOct 14, 2026
Conversation
Older @fluentui-react-native/callout JavaScript bundles request the Paper component as FRNCallout. Register FRNCalloutManager as a Swift subclass of the current RCTCalloutManager so both names resolve with the same view, properties, events, and commands. Fabric registration is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 355dde06-bddd-4395-90ce-6bd606b61339
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
4 of 10 tasks
Jason Morse (JasonVMo)
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Older
@fluentui-react-native/calloutJavaScript bundles (for example 0.28.x) request the Paper native component asFRNCallout, while the current macOS Paper manager is exported asRCTCallout. Hosts that load such a bundle against current native code fail to resolve the component.macos/components/Callout/paper/CalloutManager.swift: add@objc(FRNCalloutManager) class LegacyCalloutManager: CalloutManager {}, so the alias reuses the same view.macos/components/Callout/paper/FRNCalloutManager.m: register it withRCT_EXTERN_MODULE(FRNCalloutManager, RCTCalloutManager). Exported methods are inherited throughRCTModuleData's superclass walk, and view properties/events through the PaperbaseModuleNameview config.tests/native-ownership.test.mjs: guard that both registrations stay present.src/legacy/callout/SPEC.md: document the alias.@fluentui-react-native/native-core.RCTCalloutregistration and Fabric behavior are unchanged.Verification
node --test tests/native-ownership.test.mjs(inpackages/agentic/native-core): 7/7 passed.FRNCallouton macOS Paper find no native managerFRNCalloutresolves to the same manager asRCTCalloutPull request checklist
This PR has considered (when applicable):