Draft
Conversation
Move form code to codebehind Process review comments
- Comment CSS to check if it can be deleted - Do not fill MessageTemplate by default - Make FieldCondition use FluentText for each messsage and use the 'message' slot (instead of div's with FluentTexts) - Use correct style/color in FieldParameterCollection - Use Parameter/Attribute/Default for TextInput Message
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
- Do not put each condition in its own message slot - Update tests and verified files
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
- Add more unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR you can use
FluentValidationMessageto display the validation message like the standard BlazorValidationMesageAlso, the
FluentFieldhas been adapted so the validation messages will be displayed in the message part of the field.Unit Test need to be validated still