-
Notifications
You must be signed in to change notification settings - Fork 280
Fix ExtractFile Node 24 migration issue #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
node/task.ts
Outdated
| paths.push(path.resolve('.')); | ||
| } | ||
| const pathsCopy = [...paths]; | ||
| const pathsCopy = [...paths] as string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we fix this in the function signature of ls where path is defined as unknow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paths is kept as unknown type to supported different method overloading, removed pathsCopy type cast
…ub.com/microsoft/azure-pipelines-task-lib into users/rajmishra/ExtractFileNode24Issue
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rajmishra1997 , could you please check if we miss to upgrade the version of task-lib in package.json with this changes. from 5.2.2 to 5.2.3 ? |
Issue:
Canary Test pipeline failed after Node 24 migartion for Task ExtractFile: https://dev.azure.com/canarytest/PipelineTasks/_build/results?buildId=235044&view=results
AB#2343422
AB#2343402
Why this issue:
Solution:
Failure Scenario:

Successful Scenario
