Repository navigation
fix(autogen-agentchat): serialize TextMentionTermination sources filter - #8447
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
电大老baby (HhH666-ux) wants to merge 1 commit into
Conversation
dump_component() dropped the sources filter, so load_component() reconstructed the condition without it and terminated on the text mentioned by any source instead of only the configured ones. Team-level dump/load roundtrips hit the same path via the serialized termination condition component. Add sources to TextMentionTerminationConfig and pass it through both directions, with a roundtrip regression test. Fixes microsoft#8446
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8446.
TextMentionTermination(text, sources=[...])silently lost itssourcesfilter acrossdump_component()/load_component(): the config model only carriedtext, so a reconstructed condition terminated on the mention from any source instead of only the configured ones. Team-level roundtrips hit the same path because termination conditions are serialized as components insideSelectorGroupChatConfigand friends.Changes
sources: List[str] | None = NonetoTextMentionTerminationConfig.sourcesthrough_to_config()and_from_config().sources=Nonesurvives asNone.Testing
The repro script from #8446 now correctly returns
Nonefor a reloaded condition when the message source is outsidesources.