Repository navigation
Remove unimplemented sanitization claim from local executor docs - #8407
Open
Run_as_daemon (ranas-mukminov) wants to merge 1 commit into
Open
Run_as_daemon (ranas-mukminov) wants to merge 1 commit into
Run_as_daemon (ranas-mukminov) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
LocalCommandLineCodeExecutordocstring claims command line code is sanitized by regular expression match against a list of dangerous commands. No such list or sanitization exists in the executor or_common.py; execution goes throughasyncio.create_subprocess_exec. The same docstring carries a.. danger::warning, so the class docs contradict themselves.Change: docstring only. The sanitization sentence is removed. The
.. danger::warning is unchanged. No behavior change.Tests: none applicable (docs change). No test asserts docstring content.