Repository navigation
fix(autogen-ext): recorder no longer crashes on bare session filenames - #8369
Open
Aniket Kumar (aniketkrs) wants to merge 1 commit into
Open
Aniket Kumar (aniketkrs) wants to merge 1 commit into
Aniket Kumar (aniketkrs) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8346
User impact: recording a session to a bare filename like session.json crashes with ValueError instead of writing the file to the working directory. Users of the record and replay debugging flow have to know to prefix the path with ./ for it to work at all.
Cause: finalize() calls os.makedirs(os.path.dirname(session_file_path)). When the path has no directory part, dirname returns an empty string and makedirs raises FileNotFoundError, which the handler wraps into ValueError.
Fix: only create the directory when the path actually has a parent directory. Paths that include directories behave exactly as before. Bare filenames now write to the current working directory.
Before: os.makedirs("") raises FileNotFoundError, surfaced as ValueError.
After: parent dir guard skips makedirs for bare filenames; verified the patched file on the branch.