Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FunctionToolaccepts callables returning anAwaitable, but a synchronous tracing decorator around an async function is dispatched through the executor and its coroutine is returned without being awaited.run_jsontherefore returns a coroutine object, the underlying operation never runs, and the tool result can be serialized as a coroutine repr.Await deferred results from synchronous callables, preserving the existing cancellation contract: functions accepting
cancellation_tokenhandle it themselves; other deferred operations are linked to the token. Regression tests cover tracing decorators, partials, token injection, Future results, exception propagation, and cancellation cleanup.Validation on Windows with Python 3.12.2 and locked dependencies:
test_self_debugging_loop. The same LF/CRLF assertion failure reproduces using the original core source.chroma-hnswlib; the complete optional-extension matrix, documentation build, and .NET checks were not run.The documented API contract already permits awaitable results, so no documentation change is needed.
Related issue number
N/A
Checks