Repository navigation
Fix McpWorkbench tool call cancellation (AttributeError) - #8280
Open
Hardik K (hardikkaurani) wants to merge 2 commits into
Open
Hardik K (hardikkaurani) wants to merge 2 commits into
Hardik K (hardikkaurani) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Eric Zhu (@ekzhu) Victor Dibia (@victordibia) The fix for the MCP Workbench tool cancellation AttributeError is complete and ready for review. It properly wraps the coroutine in \�syncio.ensure_future()\ so \cancellation_token.link_future()\ can safely manage its state. Tests are included and CLA/basic checks pass. Please take a look when you have time! Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a cancellation bug in the MCP Workbench tool execution. It wraps the raw coroutine in
asyncio.ensure_future()to safely handle cancellation exceptions.Problem
When a tool execution is cancelled in the MCP Workbench, an
AttributeErroris raised because the raw coroutine cannot be properly cancelled without being wrapped in a task.Root Cause
The
McpWorkbench.call_toolmethod awaits a raw coroutine directly instead of ensuring it is a proper asyncio Task, preventing safe cancellation propagation.Changes
asyncio.ensure_future()inMcpWorkbench.call_tool.asyncio.CancelledError.Tests
Regression coverage is included for the affected behavior.
Why This Is Not a Duplicate
This PR addresses a different issue from #8284.
autogen-extwhile fix(core): preserve strict in FunctionTool component config #8284 affectsautogen-core.FunctionToolserialization.Therefore, the two PRs address independent problems and this change does not supersede or duplicate #8284.
Scope
This change is limited to
McpWorkbench.call_toolinautogen-extand does not alter other tool execution paths.