Repository navigation
fix(autogen-ext): preserve canvas tools when clearing memory - #8269
Open
Sunhy (Shy7777) wants to merge 1 commit into
Open
Sunhy (Shy7777) wants to merge 1 commit into
Sunhy (Shy7777) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TextCanvasMemory.clear()replaces the canvas, leaving tools already registered with an agent attached to the old instance. They still report successful writes, but those writes never reach the memory supplied to the next model call. Clear the files and revision history in place so existing update/patch tools and shared canvas references keep working.Related issue number
Found while testing reuse of a canvas memory after clearing it. The regression tests exercise both existing tools and shared revision history; a separate offline
AssistantAgentrun also reproduced the lost writes before the fix.Checks
Validation: the two new tests fail before the fix; all 65 related canvas, memory, context, and tool tests pass afterward. Package
poe formatandpoe lintpass, as do mypy and Pyright on the canvas module and its tests. The full extension test task needs optional Playwright dependencies absent from this environment; full-package mypy also reports errors in uninstalled optional integrations. Those broader checks are not claimed as passing.