Skip to content

[ci] Align Cursor hook smoke tests with native flat preToolUse handlers #3259

Closed

Description

Problem

Daily release smoke has failed since #3149 moved Cursor hooks to preToolUse with flat handlers. Two Cursor integration tests still expect the old nested shape:

  • tests/integration/test_hook_root_source_drift_e2e.py
  • tests/integration/test_audit_primitive_contract.py

Tracked originally by the bot-filed smoke issue #3166 (now closed). Implementation: #3198.

Expected

The Cursor drift test reads preToolUse and seeds a flat user hook. The audit test expects a nested Cursor group to be reported incomplete (native hook event requires flat handlers). Tests only; no product behaviour change.

Activity

  1. sergio-sisternes-epam commented on Oct 16, 2026

    @sergio-sisternes-epam
    CollaboratorAuthor

    Decision: approve
    Area: project
    Scope: Update the two Cursor integration tests (test_hook_root_source_drift_e2e.py, test_audit_primitive_contract.py) to expect native flat preToolUse handlers after #3149, as in #3198.
    Done when: Both [cursor] cases pass in CI and the daily release smoke no longer fails on these tests.
    Out of scope: Any change to product hook rendering or audit behaviour under src/.
    Review contact: Sergio Sisternes (@sergio-sisternes-epam)

  2. danielmeppiel commented on Oct 20, 2026

    @danielmeppiel
    Collaborator

    The bounded test-only scope is complete in #3198. The actual scheduled run at 897496177ba389c4708b110efa1ee5345ccefb79 executed all three Cursor parameterizations of the two accepted tests successfully on Linux x64/arm64 and macOS x64/arm64:

    • test_root_hook_source_drift_heals_on_reinstall[cursor]
    • test_preserved_nested_command_layout_is_visible_non_prompt[False-cursor]
    • test_preserved_nested_command_layout_is_visible_non_prompt[True-cursor]

    The two test files match merged commit b26326419a84905c3aa63bce9403e5d627417542 exactly. These are observed passes, not skipped cases or an inferred workflow result.

    The overall workflow remains red for the unrelated test_validate_hook_package_creates_package failure; Linux x64 was cancelled after the three cases passed. This closes only the accepted Cursor smoke-test issue, not the broader release failures. No product rendering or audit behavior was changed.


    Generated by autopilot-pr-merge-worker. This comment is AI-generated and may contain errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status/acceptedHuman scope approval; verify the issue's approval record and review contact before work.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions