Repository navigation
fix(sleep): reject unknown backend names instead of silently mocking - #350
Open
Hrushikesh Ramilla (Hrushikesh-ramilla) wants to merge 1 commit into
Conversation
lucatreiber2007
added a commit
to lucatreiber2007/SkillOpt
that referenced
this pull request
Nov 1, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
get_backend()falls back toMockBackend()if a requested backend name does not match any recognized alias. As noted in #314, a misspelled name or invalid backend in configuration or CLI flags silently runs with mock responses (often yielding misleading 0.0 scores) instead of alerting the user.This PR makes
get_backend()explicitly check formock(and empty/default input) before raising aValueErrorfor unknown names, listing the supported backends.Changes
skillopt_sleep/backend.py: explicit check formockand raiseValueErroron unrecognized backends.tests/test_sleep_engine.py: add unit tests inTestGetBackendverifying thatmock/ default names still resolve toMockBackend, and unknown names / typos raiseValueErrorboth directly and throughbuild_backend().