Repository navigation
fix(model): wire minimax_timeout_seconds across config, trainer, and CLI pipelines - #347
Open
Hrushikesh Ramilla (Hrushikesh-ramilla) wants to merge 1 commit into
Conversation
…CLI pipelines configure_minimax_chat supports timeout_seconds, but model.minimax_timeout_seconds was dropped during config flattening, lacked CLI flags in train.py and eval_only.py, and was not forwarded during trainer and eval initialization. This change: - Maps model.minimax_timeout_seconds in _FLATTEN_MAP (skillopt/config.py). - Adds --minimax_timeout_seconds flag and structured mapping in scripts/train.py and scripts/eval_only.py. - Forwards timeout_seconds to configure_minimax_chat in scripts/eval_only.py and skillopt/engine/trainer.py. - Documents the setting in configs/_base_/default.yaml and docs/reference/config.md. - Adds comprehensive unit tests in tests/test_minimax_config.py.
lucatreiber2007
added a commit
to lucatreiber2007/SkillOpt
that referenced
this pull request
Nov 1, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
configure_minimax_chatalready supportstimeout_seconds, butminimax_timeout_secondswas missing from the configuration pipeline and execution entry points:skillopt/config.py:model.minimax_timeout_secondswas missing from_FLATTEN_MAP, which causedflatten_config()to silently drop it.scripts/train.py:--minimax_timeout_secondswas missing from the CLI arguments and_LEGACY_TO_STRUCTUREDmapping.scripts/eval_only.py:--minimax_timeout_secondswas missing from CLI arguments and_CLI_TO_STRUCTURED, andtimeout_secondswas not forwarded toconfigure_minimax_chat(...).skillopt/engine/trainer.py:configure_minimax_chat(...)did not forwardtimeout_seconds=cfg.get("minimax_timeout_seconds").configs/_base_/default.yamlanddocs/reference/config.md:minimax_timeout_secondswas undocumented.This PR wires
minimax_timeout_secondsacross all layers so that users can configure MiniMax request timeouts via YAML configs,--cfg-options, or CLI flags in both training and evaluation workflows.Key Changes
skillopt/config.py): Added"model.minimax_timeout_seconds": "minimax_timeout_seconds"to_FLATTEN_MAP.scripts/train.py): Added--minimax_timeout_secondsCLI argument and mapped it in_LEGACY_TO_STRUCTURED.scripts/eval_only.py): Added--minimax_timeout_secondsCLI argument, mapped it in_CLI_TO_STRUCTURED, and forwardedtimeout_seconds=cfg.get("minimax_timeout_seconds")toconfigure_minimax_chat(...).skillopt/engine/trainer.py): Forwardedtimeout_seconds=cfg.get("minimax_timeout_seconds")toconfigure_minimax_chat(...)during trainer initialization.configs/_base_/default.yaml,docs/reference/config.md): Addedminimax_timeout_seconds: "300.0"under MiniMax backend settings and documented it in the configuration reference table.tests/test_minimax_config.py): Added test coverage verifying config flattening,--cfg-optionsoverrides, CLI argument parsing, and timeout propagation intrain.py,eval_only.py, andtrainer.py.Verification
pytest tests/test_minimax_config.py tests/test_minimax_backend.py tests/test_openai_compatible_config.py tests/test_codex_config_aliases.py -v: all 98 tests passed.mkdocs build --strict: passed with 0 warnings/errors.ruff check skillopt/config.py skillopt/engine/trainer.py tests/test_minimax_config.py: all checks passed.