Repository navigation
docs: correct WebUI --host default to loopback - #293
Merged
Yifan Yang (Yif-Yang) merged 1 commit intoSep 30, 2026
Merged
Yifan Yang (Yif-Yang) merged 1 commit into
Yifan Yang (Yif-Yang) merged 1 commit into
Conversation
Signed-off-by: hiro-nikaitou <vieteviete@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebUI has bound
127.0.0.1by default since the loopback hardening merged onmain(skillopt_webui/app.pyargparse default, pinned bytests/test_webui_security.py), but the README flag table and the CLI reference still listed0.0.0.0and told readers to pass--host 127.0.0.1for "local-only access" — which is already the default.What changed: both
--hostrows and the prose under them now state the loopback default and the flag that does expose the dashboard (2 files, 4 added lines).How verified:
python -m pytest tests/test_webui_security.py -q→2 passed; a doc-vs-code check asserts the documented default equals argparse's (DOC_MATCHES_CODE = True);python -m mkdocs build --strictsucceeds.Refs #288 — this covers the documentation desync only; the release cut and the staging gaps stay open.