Skip to content

fix(mine): fallback to test pool when assign_splits hashes all tasks to test - #279

Closed
RohithPariki wants to merge 1 commit into
microsoft:mainfrom
RohithPariki:fix/271-assign-splits
Closed

fix(mine): fallback to test pool when assign_splits hashes all tasks to test#279
RohithPariki wants to merge 1 commit into
microsoft:mainfrom
RohithPariki:fix/271-assign-splits

Conversation

@RohithPariki

Copy link
Copy Markdown
Contributor

Fixes #271.

When all real tasks hash to the \ est\ split, the \�ssign_splits\ function previously failed to satisfy its guarantees for non-empty \�al\ and \ rain\ splits, as the promotion logic strictly refused to pull from \ est. This silently resulted in \�al\ and \ rain\ both being empty.

This pull request implements the requested fallback:

  • Reverts to using \ est\ tasks when both \ rain\ and \�al\ are entirely empty.
  • Avoids demoting hash-assigned \ est\ tasks whenever possible by keeping existing source preferences.
  • Emits a logged warning through \logging.getLogger('skillopt_sleep').warning\ detailing the fallback and parameters.
  • Adds a robust unit test to \ ests/test_split_hardening_2x3.py\ ensuring the fallback mechanism appropriately staffs the \�al\ and \ rain\ sets in this edge case without altering behavior in normal cases.

@RohithPariki
RohithPariki deleted the fix/271-assign-splits branch September 12, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assign_splits's own non-empty-val guarantee doesn't fire when every real task hashes into test

1 participant